Restart nginx on every deploy to avoid stale upstream IPs
nginx resolves the api/web service names to a container IP once, at its own worker-process startup. docker compose up -d only recreates containers whose image/config changed, so nginx keeps proxying to the old, now-dead IP after a deploy rebuilds those containers - every request 502s, which shows up in the browser as a misleading CORS error since the bare 502 carries no Access-Control-Allow-Origin header. Confirmed live: this caused a real multi-hour production outage after the last two deploys. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This commit is contained in:
@@ -127,8 +127,11 @@ git pull
|
||||
docker compose -f docker-compose.prod.yml build api worker beat web
|
||||
docker compose -f docker-compose.prod.yml run --rm api alembic upgrade head
|
||||
docker compose -f docker-compose.prod.yml up -d
|
||||
docker compose -f docker-compose.prod.yml restart nginx
|
||||
```
|
||||
|
||||
**The `restart nginx` step is not optional.** `up -d` only recreates the containers whose image/config changed - nginx's own image/config doesn't change on an app deploy, so it keeps running with the container IPs it resolved at its *own* last startup. Once `api`/`web` get rebuilt with new IPs, nginx keeps proxying to the old, now-dead ones until something forces it to re-resolve - every request 502s (and shows up in the browser as a misleading CORS error, since a bare 502 from nginx carries no `Access-Control-Allow-Origin` header). Confirmed live: this caused a real multi-hour outage. `scripts/auto-deploy.sh` includes this step automatically.
|
||||
|
||||
**Or automatically**: `scripts/auto-deploy.sh` runs exactly that sequence, gated on "is `origin/master` ahead of `HEAD`" so it's a no-op most runs. Install it as a systemd timer (polls every 2 minutes — deliberately polling, not a Gitea webhook, so there's no extra exposed service, no Docker-socket-in-a-container, and no shared secret to manage):
|
||||
|
||||
```bash
|
||||
|
||||
Reference in New Issue
Block a user